Migrate datatree mapping.py #8948
Conversation
DAS-2064: fix circular import issue.
| @@ -4,10 +4,9 @@ | |||
| import sys | |||
There was a problem hiding this comment.
@TomNicholas - there are no significant changes to the way map_over_subtree works in this PR. As discussed today, I've opened the PR, and am happy to make changes based on conversation here.
There was a problem hiding this comment.
Okay looking at this again I can't see an obvious way to refactor it. I'm mostly just concerned that it actually makes sense to you @owenlittlejohns ?
If so then I suggest we spend the time thinking about #8949 instead
There was a problem hiding this comment.
@TomNicholas - yeah. @flamingbear and I have both spent a fair bit of time trying to grok this module. I don't claim that I've got a perfect understanding, but I feel fairly good on the whole. (The conversation yesterday that led to #8949 helped a bit, too)
There was a problem hiding this comment.
Okay great. So I guess we merge this??
FYI if you want to chat about any of this over zoom outside of the weekly meeting I would be happy to.
There was a problem hiding this comment.
I think we're good to merge!
TomNicholas
added
the
topic-DataTree
|
Thank you! |
* main: (feat): Support for `pandas` `ExtensionArray` (pydata#8723) Migrate datatree mapping.py (pydata#8948) Add mypy to dev dependencies (pydata#8947) Convert 360_day calendars by choosing random dates to drop or add (pydata#8603)
This PR continues the overall work of migrating DataTree into xarray.
datatree_mapping.pyis the renamed version ofmapping.pyfrom thedatatreerepository.mapping.pyTrack merging datatree into xarray #8572Tests addedwhats-new.rstNew functions/methods are listed inapi.rst