Allow callables to .drop_vars
#8511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used as a nice more general alternative to `.drop_indexes` or `.reset_coords(drop=True)`
for more information, see https://pre-commit.ci
headtr1ck
approved these changes
Dec 2, 2023
xarray/core/dataset.py
Outdated
| @@ -5723,16 +5723,17 @@ def _assert_all_in_dataset( | |||
|
|
|||
| def drop_vars( | |||
| self, | |||
| names: Hashable | Iterable[Hashable], | |||
| names: Hashable | Iterable[Hashable] | Callable, | |||
There was a problem hiding this comment.
Suggested change
| names: Hashable | Iterable[Hashable] | Callable, | |
| names: Hashable | Iterable[Hashable] | Callable[[Self], Hashable | Iterable[Hashable]], |
You could try this :)
And not to mention the old str | Iterable[Hashable] story. But the code below seems fine with the current definition, so we can leave it.
There was a problem hiding this comment.
Good idea. I also did some str | Iterable[Hashable] tithing
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used as a nice more general alternative to
.drop_indexesor.reset_coords(drop=True)