Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #8375

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix typos found by codespell #8375

merged 2 commits into from
Oct 26, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@max-sixty
Copy link
Collaborator

Excellent, thanks @DimitriPapadopoulos ! Lots of typos...

@max-sixty max-sixty enabled auto-merge (squash) October 25, 2023 22:54
@DimitriPapadopoulos
Copy link
Contributor Author

I am unable to identify an error in the CI jobs docs, except perhaps this warning that seems unrelated:

/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/8375/lib/python3.10/site-packages/cartopy/io/__init__.py:241: DownloadWarning: Downloading: https://naturalearth.s3.amazonaws.com/50m_physical/ne_50m_coastline.zip
  warnings.warn(f'Downloading: {url}', DownloadWarning)

Besides I am actually able to download https://naturalearth.s3.amazonaws.com/50m_physical/ne_50m_coastline.zip.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Oct 26, 2023

This warning is also unrelated as far as I can see, but should be addressed in some other PR:

WARNING: The default value for `navigation_with_keys` will change to `False` in the next release. If you wish to preserve the old behavior for your site, set `navigation_with_keys=True` in the `html_theme_options` dict in your `conf.py` file.Be aware that `navigation_with_keys = True` has negative accessibility implications:https://github.com/pydata/pydata-sphinx-theme/issues/1492

See pydata/pydata-sphinx-theme#1492 for an explanation and PR #8379 to fix this warning.

auto-merge was automatically disabled October 26, 2023 11:01

Head branch was pushed to by a user without write access

@max-sixty max-sixty enabled auto-merge (squash) October 26, 2023 14:09
@max-sixty max-sixty merged commit bb489fa into pydata:main Oct 26, 2023
27 of 28 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch October 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants