Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix matplotlib errors for single level discrete colormaps #4256

Merged
merged 3 commits into from
Mar 7, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 23, 2020

I'm not quite sure what happened, but our upstream-dev CI doesn't fail anymore. Looking at the build log, the install of the dev version of matplotlib seems to fail, so this tries to additionally remove the matplotlib-base package to see if the error comes up again if we make sure we get the dev version of matplotlib.

matplotlib released a preview version to PyPI so we can run our tests again. This follows the suggestion from #4226 (comment): convert single levels to degenerate levels.

@keewis
Copy link
Collaborator Author

keewis commented Jul 23, 2020

hmm... it seems that's because the repository is down, so now we're falling back to the PyPI version. @tacaswell, can you confirm?

@tacaswell
Copy link

It does look like the rackspace server we were pushing to seems to be down. This is more of a @matthew-brett question.

@matthew-brett
Copy link

Thanks @tacaswell :) Er - sorry - I'm lost - is the problem that xarray can't see the Matplotlib --pre binaries?

@keewis
Copy link
Collaborator Author

keewis commented Jul 23, 2020

yes, we can't seem to use pip to install the pre binaries using

python -m pip install \
        -f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com \
        --no-deps \
        --pre \
        --upgrade \
        matplotlib

also, when pointing my browser to that url, I get a resource not found page. I'm not sure if I did something different back then, but I think when I last did that about a month ago I got a page listing the available files instead.

@matthew-brett
Copy link

Yup - sorry - those URLs went down a while ago, as Tom said. Tom - are you uploading --pre binaries to Anaconda or similar?

@keewis
Copy link
Collaborator Author

keewis commented Jul 23, 2020

if not, it might be worth copying numpy, pandas and sklearn which upload to https://pypi.anaconda.org/scipy-wheels-nightly/

@tacaswell
Copy link

Can you point me at the configs that upload to the correct place?

@keewis
Copy link
Collaborator Author

keewis commented Jul 23, 2020

I don't know how those projects upload to that repository. @TomAugspurger, can you help with that?

Edit: https://github.com/MacPython/pandas-wheels/blob/master/azure/posix.yml, maybe?

@TomAugspurger
Copy link
Contributor

Yep. I believe that @ogrisel can add you to the organization on anaconda.org so that you can create a key to upload to packages.

@max-sixty
Copy link
Collaborator

max-sixty commented Oct 25, 2020

Is this & #4226 fixed now?

@keewis
Copy link
Collaborator Author

keewis commented Oct 25, 2020

no, unfortunately not: right now, we're not installing matplotlib in that CI at all. I guess we're waiting on MacPython/matplotlib-wheels#13 to get fixed, so we can install the dev version of matplotlib. After that works, we might have to fix some test failures (and we might see #4226 again).

@max-sixty
Copy link
Collaborator

Ah, thanks @keewis !

@andersy005
Copy link
Member

@keewis, is it safe to close this PR? As I understand it, this has been addressed in other PRs.

@keewis
Copy link
Collaborator Author

keewis commented Dec 28, 2020

Not sure. Removing the matplotlib-base package as well is just a placeholder for the changes I opened this PR for. Back then we noticed some failures due to changes in matplotlib upstream, but before I could debug them the rackcdn index went down.

They made some progress with uploading to scipy-wheels-nightly since then, but that was using Travis so now they're moving the upload CI to github actions.

Once that works and the wheels are available on scipy-wheels-nightly I'm planning to change this PR to have the upstream-dev CI install from there and attempt to fix any bug that may be discovered.

@andersy005
Copy link
Member

Removing the matplotlib-base package as well is just a placeholder for the changes I opened this PR for. Back then we noticed some failures due to changes in matplotlib upstream, but before I could debug them the rackcdn index went down.

Ah, I hadn't noticed that the rackcdn index was involved. My assumption was based on seeing the other upstream dev CI working :). Thank you for the clarification

@keewis keewis reopened this Mar 6, 2021
@keewis keewis closed this Mar 6, 2021
@keewis keewis reopened this Mar 6, 2021
it seems these will never be passed at that level
@keewis keewis marked this pull request as ready for review March 6, 2021 22:32
@keewis
Copy link
Collaborator Author

keewis commented Mar 6, 2021

if CI agrees this should finally be ready for merging. We still don't run our tests against nightly versions of matplotlib, but for that we will have to wait on upstream.

@keewis keewis changed the title fix upstream-dev CI fix matplotlib errors for single level discrete colormaps Mar 7, 2021
@keewis keewis merged commit 54d5817 into pydata:master Mar 7, 2021
@keewis keewis deleted the upstream-dev-ci branch March 7, 2021 13:31
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
* upstream/master: (46 commits)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
  Whatsnew for 0.17.1 (pydata#4963)
  Refinements to how-to-release (pydata#4964)
  DOC: add example for reindex (pydata#4956)
  DOC: rm np import (pydata#4949)
  Add 0.17.0 release notes (pydata#4953)
  document update as inplace (pydata#4932)
  bump the dependencies (pydata#4942)
  Upstream CI: limit runtime (pydata#4946)
  typing for numpy 1.20 (pydata#4878)
  Use definition of DTypeLike from Numpy if found (pydata#4941)
  autoupdate mypy (pydata#4943)
  Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 18, 2021
…indow

* upstream/master:
  add polyval to polyfit see also (pydata#5020)
  mention map_blocks in the docstring of apply_ufunc (pydata#5011)
  Switch backend API to v2 (pydata#4989)
  WIP: add new backend api documentation (pydata#4810)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing upstream-dev CI: matplotlib
6 participants