Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Nightly upstream-dev CI failed ⚠️ #4947

Closed
github-actions bot opened this issue Feb 24, 2021 · 7 comments · Fixed by #5006
Closed

⚠️ Nightly upstream-dev CI failed ⚠️ #4947

github-actions bot opened this issue Feb 24, 2021 · 7 comments · Fixed by #5006
Labels
CI Continuous Integration tools

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2021

Workflow Run URL

Python 3.8 Test Summary Info
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[365_day]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[360_day]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[julian]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[all_leap]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[366_day]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[gregorian]
FAILED xarray/tests/test_cftimeindex.py::test_distant_cftime_datetime_sub_cftimeindex[proleptic_gregorian]
FAILED xarray/tests/test_plot.py::TestContour::test_single_level - ValueError...
FAILED xarray/tests/test_plot.py::test_facetgrid_single_contour - ValueError:...
@github-actions github-actions bot added the CI Continuous Integration tools label Feb 24, 2021
@QuLogic
Copy link
Contributor

QuLogic commented Feb 28, 2021

FAILED xarray/tests/test_plot.py::TestContour::test_single_level - ValueError...
FAILED xarray/tests/test_plot.py::test_facetgrid_single_contour - ValueError:...

This comes from matplotlib/matplotlib#17830, as BoundaryNorm/contour needs at least two levels, but the test is explicitly using one. If that's something you think is needed, please report the use case to Matplotlib.

@keewis
Copy link
Collaborator

keewis commented Feb 28, 2021

Thanks, @QuLogic. This looks like #4226, but since rackcdn was down we didn't try to work on this (no CI to verify the changes).

Does that mean rackcdn is up again? Will you continue the effort to switch to scipy-wheels-nightly?

@QuLogic
Copy link
Contributor

QuLogic commented Feb 28, 2021

It's not migrated yet; the 3.4.0rc1 prerelease is on PyPI now.

@keewis
Copy link
Collaborator

keewis commented Feb 28, 2021

ah, thanks for the explanation. Is there anything I can do to help speed up the migration?

@keewis
Copy link
Collaborator

keewis commented Mar 6, 2021

now that the dask and matplotlib failures are (close to being) fixed we have a few errors related to cftime.

cc @spencerkclark

@spencerkclark
Copy link
Member

spencerkclark commented Mar 7, 2021

Thanks for letting me know @keewis -- it looks like pandas changed from raising an OverflowError in a particular case to raising an OutOfBoundsTimedelta error. I think this will just require modifying some exception handling logic in CFTimeIndex.__sub__ / CFTimeIndex.__rsub__. I'll try and submit a fix tomorrow.

@spencerkclark
Copy link
Member

See #5006 for a fix for the CFTimeIndex test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants