Revise pull request template

[shoyer]

See below for the new language, to clarify that documentation is only necessary
for "user visible changes."

I added "including notable bug fixes" to indicate that minor bug fixes may not
be worth noting (I was thinking of test-suite only fixes in this category) but
perhaps that is too confusing.

cc @pydata/xarray for opinions!

• Closes #xxxx
• Tests added
• Passes isort -rc . && black . && mypy . && flake8
• Fully documented, including whats-new.rst for user visible changes
  (including notable bug fixes) and api.rst for new API

[max-sixty]

I think that's reasonable

I was leaning to "everyone add their name", as it's a way of giving contributors credit, and some visible ownership — even for small changes which might be someone's first PR.

But I agree that's not always consistent with making the whatsnew better for readers.

[shoyer]

I was leaning to "everyone add their name", as it's a way of giving contributors credit, and some visible ownership — even for small changes which might be someone's first PR.

I agree, this is a nice idea.

My goals were to make things simpler for new contributors and also to make whats-new a little bit for readers.

Two ways we might still achieve this:

• We could still have a section in the release notes for each version for contributors to add their name
• We could update this manually as part of the release process (but this adds one more step for core developers)

[max-sixty]

* We could update this manually as part of the release process (but this adds one more step for core developers)

Now I think of it, we do this already:
https://github.com/pydata/xarray/blame/master/HOW_TO_RELEASE.md#L114

So maybe we paste that into the whatsnew too, and we're covered?

[dcherian]

So maybe we paste that into the whatsnew too, and we're covered?

Seems like this was the consensus at this meeting. So let's add another step to HOW_TO_RELEASE and then merge this?

[shoyer]

OK, revised.

[dcherian]

Thanks @shoyer