Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit length of dataarray reprs #3905

Merged
merged 9 commits into from
Jun 24, 2020
Merged

Limit length of dataarray reprs #3905

merged 9 commits into from
Jun 24, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Mar 27, 2020 •
edited
Loading

@max-sixty
Copy link
Collaborator Author

Our reprs aren't well tested and I've continued that tradition here. But this does stop a particularly egregious case and so I think a marginal improvement.

@max-sixty
Copy link
Collaborator Author

Ready

keewis
keewis reviewed Apr 2, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @max-sixty.

Except from a question about the tests this looks good to me.

Edit: upstream-dev fails because of #3928

xarray/tests/test_formatting.py Outdated Show resolved Hide resolved
@dcherian dcherian mentioned this pull request May 5, 2020
Closed
23 tasks
@dcherian
Copy link
Contributor

Thanks @max-sixty

@dcherian dcherian merged commit f281b3b into pydata:master Jun 24, 2020
@shoyer shoyer mentioned this pull request Jun 24, 2020
Closed
dcherian added a commit to raphaeldussin/xarray that referenced this pull request Jul 1, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix_facecolor_plot
b1c15ad 
* upstream/master: (21 commits)
  fix typo in error message in plot.py (pydata#4188)
  Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods (pydata#3936)
  Show data by default in HTML repr for DataArray (pydata#4182)
  Blackdoc (pydata#4177)
  Add CONTRIBUTING.md for the benefit of GitHub
  Correct dask handling for 1D idxmax/min on ND data (pydata#4135)
  use assert_allclose in the aggregation-with-units tests (pydata#4174)
  Remove old auto combine (pydata#3926)
  Fix 4009 (pydata#4173)
  Limit length of dataarray reprs (pydata#3905)
  Remove <pre> from nested HTML repr (pydata#4171)
  Proposal for better error message about in-place operation (pydata#3976)
  use builtin python types instead of the numpy alias (pydata#4170)
  Revise pull request template (pydata#4039)
  pint support for Dataset (pydata#3975)
  drop eccodes in docs (pydata#4162)
  Update issue templates inspired/based on dask (pydata#4154)
  Fix failing upstream-dev build & remove docs build (pydata#4160)
  Improve typehints of xr.Dataset.__getitem__ (pydata#4144)
  provide a error summary for assert_allclose (pydata#3847)
  ...
@max-sixty max-sixty deleted the long-array-repr branch July 11, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truncate array repr based on line count
3 participants
@max-sixty @dcherian @keewis