Add Context.set_tlsext_use_srtp #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaine
force-pushed
the
tlsext-srtp
branch
2 times, most recently
from
66e59c6
to
e8b810e
Compare
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 97.05% 97.06% +0.01%
==========================================
Files 18 18
Lines 5705 5726 +21
Branches 395 396 +1
==========================================
+ Hits 5537 5558 +21
Misses 112 112
Partials 56 56
Continue to review full report at Codecov.
|
|
I'm not sure what the best form would be for the "profiles" argument. Two possibilities:
Suggestions? |
|
I dislike the OpenSSL APIs for this, but pyOpenSSL generally doesn't abstract much away and since we already have an API that exposes colon delimited behavior it probably makes sense for this one to look like that as well. One day we'll have a nice TLS API. pyOpenSSL won't be it... |
|
OK thanks for the feedback I'll write the corresponding API docs. Quick question : any reason why we don't use sphinx.autodoc's automethod? It seems a shame to have to duplicate the docstrings everywhere. |
|
We do for new code. Nobody wanted to spend their time to move everything to docstrings yet. |
|
Duly noted, I've updated my pull request to use automethod |
jlaine
force-pushed
the
tlsext-srtp
branch
2 times, most recently
from
77350e9
to
bcd6ce9
Compare
|
This requires #742 |
This allows negotiating SRTP keying material, which is useful when using DTLS-SRTP, as WebRTC does for example.
|
@reaperhulk anything you'd like me to change with this PR? |
|
@jlaine could you rebase this? |
|
Actually I can resolve, nevermind :) |
reaperhulk
approved these changes
May 16, 2018
bors-fusion bot
referenced
this pull request
in fusionapp/fusion-index
May 21, 2018
197: Scheduled weekly dependency update for week 20 r=mithrandi a=pyup-bot ### Update [hypothesis](https://pypi.org/project/hypothesis) from **3.56.5** to **3.57.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/hypothesis - Repo: https://github.com/HypothesisWorks/hypothesis/issues </details> ### Update [pbr](https://pypi.org/project/pbr) from **4.0.2** to **4.0.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pbr - Homepage: https://docs.openstack.org/pbr/latest/ </details> ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 <https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 <https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 <https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details>
bors-fusion bot
referenced
this pull request
in fusionapp/documint
May 21, 2018
134: Scheduled weekly dependency update for week 20 r=mithrandi a=pyup-bot ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 <https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 <https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 <https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details>
bors-fusion bot
referenced
this pull request
in fusionapp/entropy
May 28, 2018
188: Scheduled weekly dependency update for week 21 r=mithrandi a=pyup-bot ### Update [pyasn1](https://pypi.org/project/pyasn1) from **0.4.2** to **0.4.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyasn1 - Changelog: https://pyup.io/changelogs/pyasn1/ - Repo: https://github.com/etingof/pyasn1 </details> ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 <https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 <https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 <https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details> ### Update [python-dateutil](https://pypi.org/project/python-dateutil) from **2.7.2** to **2.7.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/python-dateutil - Changelog: https://pyup.io/changelogs/python-dateutil/ - Docs: https://dateutil.readthedocs.io </details> Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows negotiating SRTP keying material, which is useful when using
DTLS-SRTP, as WebRTC does for example.
This depends on:
pyca/cryptography#4099