Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing causal mechanisms when creating GCM #1210

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented Jun 18, 2024

Before, when a causal graph had causal mechanisms assigned, they were also used when creating a new GCM object based on it. Now, they are removed (from a copied version of the graph) if the new flag is set to True.

@bloebp bloebp requested a review from amit-sharma June 18, 2024 01:21
@bloebp bloebp force-pushed the gcm_fix_graph branch 2 times, most recently from aaf3ddd to 48dcaeb Compare June 18, 2024 14:39
Before, when a causal graph had causal mechanisms assigned, they were also used when creating a new GCM object based on it. Now, they are removed (from a copied version of the graph).

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
@bloebp bloebp merged commit 474c584 into main Jul 29, 2024
30 checks passed
@bloebp bloebp deleted the gcm_fix_graph branch July 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants