Add examples from "Causal Inference and Discovery in Python" to tests #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulbshrestha
force-pushed
the
test_causal_inference_discovery_book
branch
from
3e15831
to
518ba93
Compare
rahulbshrestha
force-pushed
the
test_causal_inference_discovery_book
branch
from
8f93548
to
fbc80d8
Compare
amit-sharma
reviewed
May 9, 2024
There was a problem hiding this comment.
Thanks for this PR @rahulbshrestha . Apologies it took me longer than I thought to review this.
The PR looks great. I just added a couple of minor comments. Once you address them, I'm happy to merge.
tests/causal-inference-discovery-book/test_causal_inference_discovery_book.py
Show resolved
Hide resolved
tests/causal-inference-discovery-book/test_causal_inference_discovery_book.py
Outdated
Show resolved
Hide resolved
amit-sharma
reviewed
May 9, 2024
tests/causal-inference-discovery-book/test_causal_inference_discovery_book.py
Outdated
Show resolved
Hide resolved
amit-sharma
reviewed
May 9, 2024
tests/causal-inference-discovery-book/test_causal_inference_discovery_book.py
Outdated
Show resolved
Hide resolved
rahulbshrestha
force-pushed
the
test_causal_inference_discovery_book
branch
from
db8a1ee
to
8eb290a
Compare
|
Thanks for the edits, @rahulbshrestha There is a build error due to config issue with econml tests. I will resolve that and merge this PR after that. |
Signed-off-by: Rahul Shrestha <rahulshrestha0101@gmail.com> added chapter 6 Fix Signed-off-by: Rahul Shrestha <rahulshrestha0101@gmail.com> Add chapter 8 Signed-off-by: Rahul Shrestha <rahulshrestha0101@gmail.com> Fix formatting issue with linter Add references
Signed-off-by: rahulbshrestha <rahulshrestha0101@gmail.com>
Signed-off-by: rahulbshrestha <rahulshrestha0101@gmail.com>
rahulbshrestha
force-pushed
the
test_causal_inference_discovery_book
branch
from
d04360b
to
ec6351c
Compare
Signed-off-by: Amit Sharma <amit_sharma@live.com>
amit-sharma
approved these changes
Aug 4, 2024
|
Thanks you @rahulbshrestha for adding these tests. sorry for the delay in fixing the econml dependencies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add tests from the book "Causal Inference and Discovery In Python" (link) in order to ensure backwards compatibility to future releases of doWhy
Related issue: Add examples from "Causal Inference and Discovery in Python" to the tests to ensure backwards compatibility #970