Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATE validation - uplift uniform confidence bands #840

Merged
merged 13 commits into from
Mar 19, 2024

Conversation

amarvenu
Copy link
Contributor

Added additional functionality to the DRTester validation class to include uniform confidence bands (both two- and one-sided) for uplift curve plots, calculated via the multiplier bootstrap.

Modified files are:

  • econml/validate/* (main code files)
  • econml/tests/test_drtester.py (test cases)
  • notebooks/CATE validation.ipynb (example usage notebook)

Test cases were extended to include the modifications, maintaining 100% coverage:
Screen Shot 2024-01-17 at 6 34 48 PM

Looking forward to any comments.

Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great, added a few minor suggestions.

econml/validate/results.py Outdated Show resolved Hide resolved
econml/validate/results.py Outdated Show resolved Hide resolved
econml/validate/results.py Outdated Show resolved Hide resolved
econml/validate/results.py Outdated Show resolved Hide resolved
econml/validate/utils.py Outdated Show resolved Hide resolved
amarvenu and others added 11 commits March 19, 2024 00:46
…rs for uplift curves

Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
…ling

Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com>
Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com>
Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com>
Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com>
Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi merged commit 27d3101 into py-why:main Mar 19, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants