Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook for DRIV #518

Merged
merged 9 commits into from
Feb 2, 2022
Merged

Add notebook for DRIV #518

merged 9 commits into from
Feb 2, 2022

Conversation

heimengqi
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I've suggested a few very minor grammar fixes as well as a couple of other small suggestions.

doc/spec/estimation/orthoiv.rst Outdated Show resolved Hide resolved
doc/spec/estimation/orthoiv.rst Outdated Show resolved Hide resolved
doc/spec/estimation/orthoiv.rst Outdated Show resolved Hide resolved
doc/spec/estimation/orthoiv.rst Outdated Show resolved Hide resolved
doc/spec/estimation/orthoiv.rst Show resolved Hide resolved
notebooks/OrthoIV and DRIV Examples.ipynb Outdated Show resolved Hide resolved
notebooks/OrthoIV and DRIV Examples.ipynb Outdated Show resolved Hide resolved
notebooks/OrthoIV and DRIV Examples.ipynb Show resolved Hide resolved
@heimengqi
Copy link
Contributor Author

This looks great. I've suggested a few very minor grammar fixes as well as a couple of other small suggestions.

Thanks Keith! I've addressed majority of your comments.

@kbattocchi kbattocchi force-pushed the mehei/drivdoc branch 2 times, most recently from 2e384a6 to 7240f69 Compare January 31, 2022 09:54
@kbattocchi kbattocchi force-pushed the mehei/drivdoc branch 2 times, most recently from d4a7138 to f7affde Compare January 31, 2022 10:04
@kbattocchi kbattocchi force-pushed the mehei/drivdoc branch 3 times, most recently from b3221ae to bb7613d Compare February 2, 2022 16:25
@kbattocchi kbattocchi merged commit b030fb6 into main Feb 2, 2022
@kbattocchi kbattocchi deleted the mehei/drivdoc branch February 2, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants