Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official actions/create-github-app-token for auto-merge #736

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

PerchunPak
Copy link
Member

Currently CI fails with:

Run tibdex/github-app-token@v2
  with:
    github_api_url: https://github.com/gitapi/
    installation_retrieval_mode: repository
    installation_retrieval_payload: py-mine/mcstatus
    revoke: true

Error: Input required and not supplied: app_id
    at getInput (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:1:3828)
    at parseOptions (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:87889)
    at file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:87507
    at run (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:88817)
    at file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:87480
    at __nccwpck_require__.a (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:368729)
    at 399 (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:87363)
    at __nccwpck_require__ (file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:367817)
    at file:///home/runner/work/_actions/tibdex/github-app-token/v2/dist/main/index.js:9:369615
    at ModuleJob.run (node:internal/modules/esm/module_job:217:25)

Firstly I thought ItsDrike forgot to add app_id argument, but it is false. Then I looked at tibdex/github-app-token's issue tracker and found tibdex/github-app-token#99.

So this issue is probably a bug somewhere in the action, but as there is an official alternative to this GH action, why not use it instead? Furthermore, it seems to be actively maintained, so we shouldn't face such fundamental errors.

@PerchunPak PerchunPak added the area: CI Related to continuous intergration and deployment label Feb 2, 2024
Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! Didn't know there was an official action.

Yeah, I'm pretty confused by that CI error, I've re-created the CI_BOT_APP_ID secret var, just in case I accidentally created it with just an empty value or something, but I doubt it, it is indeed possible that this is a bug in the action, which would explain the error.

Let's see what happens with the official action then.

@ItsDrike ItsDrike merged commit 9730a3d into master Feb 2, 2024
9 checks passed
@ItsDrike ItsDrike deleted the actions-create-github-app-token branch February 2, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI Related to continuous intergration and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants