Address pandas deprecation warnings #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like ME only exists for pandas 2.2+
kandersolar
added
remote-data
|
Ready for review. The linter is complaining about lines I didn't touch, so I didn't fix them. I'm not sure why codecov is failing. |
AdamRJensen
approved these changes
Mar 19, 2024
| @@ -146,7 +146,7 @@ def read_surfrad(filename, map_variables=True): | |||
| metadata['surfrad_version'] = int(metadata_list[-1]) | |||
| metadata['tz'] = 'UTC' | |||
|
|
|||
| data = pd.read_csv(file_buffer, delim_whitespace=True, | |||
| data = pd.read_csv(file_buffer, sep=r'\s+', | |||
There was a problem hiding this comment.
The warning states:
"FutureWarning: The 'delim_whitespace' keyword in pd.read_csv is deprecated and will be removed in a future version. Use sep='\s+' instead",
Is there a reason that you're using a single backslash?
There was a problem hiding this comment.
sep='\\s+' is equivalent to sep=r'\s+', I just preferred to use an r string instead of escaping the backslash
There was a problem hiding this comment.
I figured - thanks for letting me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.See #1994 (comment).
This PR addresses many pandas deprecation warnings. Most of them are just frequency string replacements like
H -> hin calls topd.date_range, but there are some others as well. For future reference, here are the warnings addressed:sep='\\s+'instead",There are two warnings remaining. The first is:
MEdoesn't exist until pandas 2.2, so we can't use it yet. This is only four warnings intest_clearsky.py, so we can live with it for now.The second is a warning where we are already doing the right/future-compatible thing, but I don't know how to suppress the warning. I guess we should ignore it until it eventually goes away:
replaceis deprecated and will be removed in a future version. To retain the old behavior, explicitly callresult.infer_objects(copy=False). To opt-in to the future behavior, setpd.set_option('future.no_silent_downcasting', True)