Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize 0.10.4 #1994

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Finalize 0.10.4 #1994

merged 4 commits into from
Mar 19, 2024

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Mar 18, 2024

  • Closes v0.10.4 release planning #1992
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Leaving as draft while reviewing the various CI jobs

@kandersolar kandersolar added this to the v0.10.4 milestone Mar 18, 2024
@kandersolar kandersolar changed the title finalize whatsnew Finalize 0.10.4 Mar 18, 2024
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Mar 18, 2024
@kandersolar
Copy link
Member Author

Inspecting the test output, I see a few warnings like this:

  /Users/runner/work/pvlib-python/pvlib-python/pvlib/inverter.py:535: FutureWarning: ChainedAssignmentError: behaviour will change in pandas 3.0!
  You are setting values through chained assignment. Currently this works in certain cases, but when using Copy-on-Write (which will become the default behaviour in pandas 3.0) this will never work to update the original DataFrame or Series, because the intermediate object on which we are setting values will behave as a copy.
  A typical example is when you are setting values in a column of a DataFrame, like:
  
  df["col"][row_indexer] = value
  
  Use `df.loc[row_indexer, "col"] = values` instead, to perform the assignment in a single step and ensure this keeps updating the original `df`.
  
  See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  
    coeffs['a'][d] = a

and many warnings like this:

  /Users/runner/work/pvlib-python/pvlib-python/pvlib/tests/test_temperature.py:257: FutureWarning: 'H' is deprecated and will be removed in a future version, please use 'h' instead.

The former is coming from inverter.py, so inside pvlib itself. I'm not immediately seeing a hard release date for pandas 3.0, but it might be as early as April 1 (https://github.com/pandas-dev/pandas/milestone/102), so before our next release. I will submit a PR to fix those in this release.

The latter is from the tests, so lesser priority to fix, but easy enough so might as well.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add docs/sphinx/source/whatsnew/v0.10.5.rst

docs/sphinx/source/whatsnew/v0.10.4.rst Outdated Show resolved Hide resolved
@kandersolar kandersolar marked this pull request as ready for review March 19, 2024 14:32
@kandersolar
Copy link
Member Author

I'll proceed with making the release. Many thanks as always to all contributors!

@kandersolar kandersolar merged commit 2f04c26 into pvlib:main Mar 19, 2024
33 of 34 checks passed
@kandersolar kandersolar deleted the v0.10.4-release branch March 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.10.4 release planning
3 participants