You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
Pull request is nearly complete and ready for detailed review.
Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.
The SRML data is now again available following the original structure, but the URL has changed. Note, the URL in the get_srml function has already been updated previously, so this PR is only related to tests (hence no whatsnew entry).
Note, the URL in the get_srml function has already been updated previously, so this PR is only related to tests (hence no whatsnew entry).
No whatsnew for the changes in this PR makes sense, but shouldn't we have one for updating the URL in get_srml? If get_srml in 0.10.3 doesn't work out of the box anymore, but get_srml in 0.10.4 does, that sounds like a user-facing bug fix to me :)
No whatsnew for the changes in this PR makes sense, but shouldn't we have one for updating the URL in get_srml? If get_srml in 0.10.3 doesn't work out of the box anymore, but get_srml in 0.10.4 does, that sounds like a user-facing bug fix to me :)
I agree, although this was not done in this PR but in a PR that cleaned up broken links. I've gone ahead an updated the whatsnew in this PR nevertheless
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdamRJensen
changed the title
[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The SRML data is now again available following the original structure, but the URL has changed. Note, the URL in the
get_srmlfunction has already been updated previously, so this PR is only related to tests (hence no whatsnew entry).The SRML tests were disabled in #1921.