Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pvlib.iotools.get_srml to adhere to SRML's new file structure #1931

Closed
wants to merge 7 commits into from

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Dec 19, 2023

  • Closes Re-enable SRML tests #1922
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR modifies the pvlib.iotools.get_srml to adhere to the new SRML file structure. That means that this is a breaking change and the get_srml function in previous versions of pvlib will not work. For this reason, the iotools.read_srml_month_from_solardat is also deprecated earlier than anticipated.

@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Dec 19, 2023
@AdamRJensen AdamRJensen marked this pull request as draft December 19, 2023 18:36
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Dec 19, 2023
@adriesse
Copy link
Member

This PR modifies the pvlib.iotools.get_srml to adhere to the new SRML file structure.

Wanna put some hints here as to what changed?

@AdamRJensen
Copy link
Member Author

This PR modifies the pvlib.iotools.get_srml to adhere to the new SRML file structure.

Wanna put some hints here as to what changed?
The changes have not been finalized, which is why I've left this PR as a draft. But the files will most likely no longer be all in one big folder but be placed in subfolders by station and years.

@AdamRJensen
Copy link
Member Author

Closing this PR in favor of #1988 and #1989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable SRML tests
2 participants