Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use barrier to generate badges #211

Merged
merged 2 commits into from
May 1, 2016

Conversation

tfausak
Copy link
Contributor

@tfausak tfausak commented May 1, 2016

This fixes #102.

I decided to use barrier because it's what Stackage uses. Check out their badge handler to see how it works.

@tfausak
Copy link
Contributor Author

tfausak commented May 1, 2016

Almost forgot to post screenshots! Before:

screen shot 2016-05-01 at 6 54 25 am

After:

screen shot 2016-05-01 at 6 52 53 am

@hdgarrood
Copy link
Collaborator

Looks great :)

Just one thing: I think I'd rather use the renderBadge function, since then I don't think we need to import the Internal module. Then I think you can use preEscapedToMarkup to turn the ByteString into Svg.

This avoids using the internal module from barrier.
@tfausak
Copy link
Contributor Author

tfausak commented May 1, 2016

👍 I had to use unsafeLazyByteString instead of preEscapedToMarkup because there's no ByteString instance for ToMarkup.

@hdgarrood
Copy link
Collaborator

Looks great, thanks!

@hdgarrood hdgarrood merged commit 8f21c38 into purescript:master May 1, 2016
@tfausak tfausak deleted the gh-102-shields-io branch May 1, 2016 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shields.io for badges
2 participants