Fix annotations in puppetdb-pvc and puppetserver-pvc #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiryushin
requested review from
a team,
Xtigyro and
davidphay
as code owners
|
|
akiryushin
changed the title
|
Thanks for the PR! can you please sign the CLA & bump the |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
akiryushin
force-pushed
the
st_annotation_fix
branch
3 times, most recently
from
d258dde
to
31279b7
Compare
|
Done |
akiryushin
force-pushed
the
st_annotation_fix
branch
from
02c5810
to
08fd9e7
Compare
|
I add 2 suggestions, after that it will be ok for me. |
|
@akiryushin Hello, you have to rebase your branch, many commit has been added. |
akiryushin
force-pushed
the
st_annotation_fix
branch
from
08fd9e7
to
14a32d3
Compare
akiryushin
force-pushed
the
st_annotation_fix
branch
from
4a9325d
to
09da12d
Compare
|
@davidphay done |
akiryushin
force-pushed
the
st_annotation_fix
branch
from
09da12d
to
0fe91c9
Compare
|
@akiryushin in |
|
@davidphay sorry, didn't see. Check it |
davidphay
approved these changes
Jan 27, 2023
CHANGELOG.md
Outdated
| @@ -5,6 +5,9 @@ numbering uses [semantic versioning](http://semver.org). | |||
|
|
|||
| NOTE: The change log until version `v0.2.4` is auto-generated. | |||
|
|
|||
| ## [v7.1.1](https://github.com/puppetlabs/puppetserver-helm-chart/tree/v7.0.0) (2023-01-xx) | |||
There was a problem hiding this comment.
Suggested change
| ## [v7.1.1](https://github.com/puppetlabs/puppetserver-helm-chart/tree/v7.0.0) (2023-01-xx) | |
| ## [v7.1.1](https://github.com/puppetlabs/puppetserver-helm-chart/tree/v7.2.2) (2023-01-18) |
Please update the date here
davidphay
pushed a commit
to davidphay/puppetserver-helm-chart
that referenced
this pull request
Jan 27, 2023
* Fix annotations in puppetdb-pvc * Fix puppetserver-pvc annotation * Add akiryushin as Contributor * Bump chart * Fix puppetserver-pvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.