(maint) ruby-openssl now sets store_context.error #8829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
force-pushed
the
maint_openssl
branch
from
4ad837f
to
6c3423b
Compare
Ruby now correctly sets the store_context.error when the cert is mismatched[1], [2]. So in that case raise the expected CertMismatchError. We also have to monkey patch the ruby constant, which was only recently added to match openssl 1.1[3]. [1] ruby/openssl#244 [2] ruby/openssl@74ef8c0 [3] ruby/openssl@65ea09c
joshcooper
force-pushed
the
maint_openssl
branch
from
6c3423b
to
838f9e0
Compare
ciprianbadescu
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby now correctly sets the store_context.error when the cert is mismatched[1], [2]. So
in that case raise the expected CertMismatchError.
We also have to monkey patch the ruby constant, which was only recently added to
match openssl 1.1[3].
[1] ruby/openssl#244
[2] ruby/openssl@74ef8c0
[3] ruby/openssl@65ea09c