Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pictures are stretched when opening them #176

Closed
TtuxX opened this issue Nov 8, 2022 · 9 comments
Closed

Some pictures are stretched when opening them #176

TtuxX opened this issue Nov 8, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@TtuxX
Copy link

TtuxX commented Nov 8, 2022

Hi there @pulsejet :)

When I open some pictures from the timeline I see 3 strange things:

  • On some pictures I cannot zoom (when I open the picture, I only get a "dezoom" mouse and clic action)
  • All pictures appear to be zoomed-in a bit by default to fit screen; thus
  • Pictures are getting deformed to match browser's window dimensions

Thank you in advance for your help and a big applause for all the updates and new features you are adding to the app :)

Best regards

@pulsejet
Copy link
Owner

pulsejet commented Nov 9, 2022

You cannot zoom photos which are already smaller than your screen dimensions on desktop (this should still work on mobile). But the pictures definitely shouldn't be stretched. Can you provide one or two sample images along with spec such as device, browser, resolution etc.?

@pulsejet pulsejet added the bug Something isn't working label Nov 9, 2022
@MoskiT87
Copy link

MoskiT87 commented Nov 9, 2022

I can provide sample
Image

@MoskiT87
Copy link

MoskiT87 commented Nov 9, 2022

The image is stretched to fill the window
Laptop, Chrome Browser, 1920x1080, php 8.1 on server side.

@TtuxX
Copy link
Author

TtuxX commented Nov 9, 2022

You cannot zoom photos which are already smaller than your screen dimensions on desktop (this should still work on mobile).

Would it still be possible to have the option to zoom in on desktop?

This would be very convenient when you are multitasking and have several small windows displayed side by side along with your browser's window on a large screen.

Furthermore, I thing that having a powerful zooming effect with a mouse scroll is not really a problem as it's up to the user to zoom until the point he nearly gets pixels (but can be quite useful when you show a picture detail to somebody who is few meters away from your screen).

But the pictures definitely shouldn't be stretched. Can you provide one or two sample images along with spec such as device, browser, resolution etc.?

I confirm that I have exactly the same image effects as @MoskiT87 (latest Firefox version on Mac).

@pulsejet
Copy link
Owner

pulsejet commented Nov 9, 2022

I can provide sample

I need an image file, not a screenshot.

@pulsejet
Copy link
Owner

pulsejet commented Nov 9, 2022

You cannot zoom photos which are already smaller than your screen dimensions on desktop (this should still work on mobile).

Would it still be possible to have the option to zoom in on desktop?

This would be very convenient when you are multitasking and have several small windows displayed side by side along with your browser's window on a large screen.

Furthermore, I thing that having a powerful zooming effect with a mouse scroll is not really a problem as it's up to the user to zoom until the point he nearly gets pixels (but can be quite useful when you show a picture detail to somebody who is few meters away from your screen).

Basically the viewer library (PhotoSwipe) does not support this (at least out of the box), so it remains to be seen how this could be done.

pulsejet added a commit that referenced this issue Nov 10, 2022
@pulsejet
Copy link
Owner

You probably just need to run occ memories index or occ memories index -f to fix this. Basically this happens when the db is missing dimensions info about the image.

@pulsejet
Copy link
Owner

@TtuxX you can use Ctrl + Mouse wheel to zoom on desktop.
Of course this won't work on images not indexed properly (those that appear stretched). See my previous comment.

@illnesse
Copy link

@pulsejet fwiw i noticed this the other day with a .HEIC file, it was a landscape photo displayed as portrait and no rotation in the EXIF data, going to post details next time i see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants