Fix content__in filter #5818
Merged
Fix content__in filter #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
content_in_fix
branch
2 times, most recently
from
2be5dcf
to
6eb769d
Compare
mdellweg
reviewed
Sep 23, 2024
| file_random_content_unit, | ||
| file_content_unit_with_name_factory, |
Comment on lines
+365
to
+366
| class WithContentInFilter(BaseInFilter, WithContentFilter): | ||
| """The multi-content variant of WithContentFilter.""" |
There was a problem hiding this comment.
Is the BaseInFilter what fixes the openapi3 schema in this case?
There was a problem hiding this comment.
Yes, I'll add a schema test for this.
gerrod3
force-pushed
the
content_in_fix
branch
from
6eb769d
to
1dc5539
Compare
mdellweg
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3634