Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis build #65

Merged
merged 17 commits into from
Feb 25, 2022
Merged

Fix travis build #65

merged 17 commits into from
Feb 25, 2022

Conversation

stmpjmpr
Copy link
Contributor

I made changes to fix the linter/Clippy errors, as well as formatter errors that were causing the build to fail. Important to note:

  • Minimum Rust version is now 1.49.0, due to features that cause warnings in 1.46.0 now.
  • I widened what is allowed for unknown, renamed, and removed lints, due to a changed linter name that either breaks the minimum version, or the current version, mutually exclusive. I added TODOs noting when we can re-enable the check in the future.
  • There were quite a few places where unnecessary dereferences were taking place, and semicolons added where no value was being returned and used.

…tead.

* Added semicolon to line where nothing was being returned in runtime.rs
* Removed `async` from function where there was no `await` in subscribe_loop.rs
* Refactored assertion in subscription.rs to make clippy happy.
…e_loop.rs since clippy was too aggressive in requiring its removal.
… `broken_intra_doc_links` and newer ones use `rustdoc::broken_intra_doc_links`, so the build fails on one or the other, so allowing unknown lints for now.
…broken_intra_doc_links`

* More fixing of unnecessary semicolons
…e...that is immediately dereferenced by the compiler"
… lints when Rust 1.59.0 becomes minimum version.
Copy link

@phairow phairow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had some questions since I am new to rust but it looks good overall.

pubnub-core/src/lib.rs Show resolved Hide resolved
pubnub-core/src/mock/runtime.rs Show resolved Hide resolved
pubnub-core/src/subscription/subscription.rs Show resolved Hide resolved
@stmpjmpr stmpjmpr merged commit ef8379e into master Feb 25, 2022
@stmpjmpr stmpjmpr deleted the fix-travis-build branch February 25, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants