Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --timeout when running benchmarks #205

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Implement --timeout when running benchmarks #205

merged 6 commits into from
Sep 26, 2024

Conversation

diegorusso
Copy link
Contributor

If the benchmark execution is exceeding the timeout execution, pyperf exits with an error 124. This error can be caught by pyperformance or other tool and report it back to the user.

@diegorusso
Implement --timeout when running benchmarks
0293c7d 
If the benchmark execution is exceeding the timeout execution, pyperf
exits with an error 124. This error can be caught by pyperformance or
other tool and report it back to the user.
vstinner
vstinner reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the overall approach, but here is a review on the actual implementation.

pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/_manager.py Outdated Show resolved Hide resolved
pyperf/_utils.py Outdated Show resolved Hide resolved
@diegorusso diegorusso mentioned this pull request Sep 24, 2024
Merged
vstinner
vstinner reviewed Sep 24, 2024
View reviewed changes
pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/_utils.py Outdated Show resolved Hide resolved
pyperf/tests/test_runner.py Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the change works as expected :-)

$ python -m pyperf timeit 'import time; time.sleep(5)' --timeout=2
Timed out after 2 seconds

vstinner
vstinner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 07d2a77 into psf:main Sep 26, 2024
13 checks passed
@vstinner
Copy link
Member

Merged, thanks.

@diegorusso diegorusso mentioned this pull request Sep 30, 2024
Open
@diegorusso diegorusso deleted the timeout branch October 2, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegorusso @vstinner