fix: respect braces better in f-string parsing #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a changelog entry since this fixes crashes on some real-world code? Also might be worth adding a few more test cases; I'll take a look tonight and maybe push some too. |
|
This fixes the two crashing cases, but doesn't fix the incorrect parses. Still looking into that one. |
|
|
|
I have a fix for the remaining cases locally, will put up a PR once #4423 is done. |
|
@JelleZijlstra I just made a fix, see if you can find any bugs with this one? |
JelleZijlstra
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny inconsistency between two regexes, one had a part changed to
\\[^{]whereas the other was left to be\\., causing a crash in parsing in some cases.The regex was a bit unreasonably complex though, it doesn't need to have
\\.or\\[^{]in it anyway. This simplifies the regex and makes it more compatible.Resolves #4421