Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation solution for f-string problems on 3.12 python version #4372

Closed
wants to merge 2 commits into from
Closed

Implementation solution for f-string problems on 3.12 python version #4372

wants to merge 2 commits into from

Conversation

devshah9
Copy link

@devshah9 devshah9 commented May 26, 2024 •
edited

Description

Fixes #4350

Fixes the F-strings issues for python 3.12 or new versions and give proper error on f-strings not compile

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 26, 2024 •
edited

diff-shades reports zero changes comparing this PR (aa3f319) to main (9c1fd46).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra
Copy link
Collaborator

Thank you! Could you add tests?

@devshah9
Copy link
Author

Sure let me try that out

@devshah9
"Update linegen.py, strings.py, and pep_701.py with minor changes to …
aa3f319 
…token handling, string normalization, and f-string quotes."
@tusharsadhwani
Copy link
Contributor

This breaks:

f"{f'\''}"

@JelleZijlstra
Copy link
Collaborator

This was fixed in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devshah9 @JelleZijlstra @tusharsadhwani