Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop moving multiline strings to a new line unless inside brackets #4289

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

cobaltt7
Copy link
Contributor

@cobaltt7 cobaltt7 commented Mar 22, 2024

Description

Resolves #4247

I fixed it by not wrapping around multiline strings outside brackets. This keeps all existing tests passing while allowing assert statements to not be reformatted. This is currently gated under the multiline_string_handling unstable style, since it's the smallest solution to just add it in there.

Checklist - did you ...

  • [y] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@cobaltt7 cobaltt7 changed the title fix: Stop moving multiline strings to a new line inside brackets fix: Stop moving multiline strings to a new line unless inside brackets Mar 22, 2024
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Copy link

diff-shades reports zero changes comparing this PR (001ab8f) to main (c9d2635).


What is this? | Workflow run | diff-shades documentation

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@JelleZijlstra JelleZijlstra merged commit 13bd092 into psf:main Mar 23, 2024
46 checks passed
@cobaltt7 cobaltt7 deleted the gh-4247 branch March 23, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion with multi-line string needlessly spans multiple lines
3 participants