Add POST /eth/v2/beacon/pool/attester_slashings
#14480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
commented
Sep 30, 2024
rkapka
reviewed
Oct 10, 2024
rkapka
reviewed
Oct 10, 2024
| func (s *Server) attesterSlashing( | ||
| w http.ResponseWriter, | ||
| ctx context.Context, | ||
| slot primitives.Slot, |
There was a problem hiding this comment.
Why pass the slot when we can get it from slashing?
There was a problem hiding this comment.
Well I had to make the slashing type useable by both Electra and non electra and using the slot from this slashing would be:
slashing.FirstAttestation().GetData().Slot
It seemed simpler to just pass the slot
rkapka
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Beacon API Electra alignment, add missing endpoint for POST
/eth/v2/beacon/pool/attester_slashings.As described in the spec https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/submitPoolAttesterSlashingsV2
Which issues(s) does this PR fix?
Part of #14476
Other notes for review
Acknowledgements