Add unit tests of ExecutionPayloadEnvelope verification
#14373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonsong
requested review from
saolyn,
potuz and
terencechain
and removed request for
a team
| // GossipExecutionPayloadEnvelopeRequirements is a requirement list for gossip payload attestation messages. | ||
| var GossipExecutionPayloadEnvelopeRequirements = RequirementList(PayloadAttGossipRequirements) | ||
| // GossipExecutionPayloadEnvelopeRequirements is a requirement list for gossip execution payload envelopes. | ||
| var GossipExecutionPayloadEnvelopeRequirements = RequirementList(ExecutionPayloadEnvelopeGossipRequirements) |
potuz
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
potuz
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Correct requirement list of EnvelopeVerifier * Add unit tests of ExecutionPayloadEnvelope verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds unit tests of
ExecutionPayloadEnvelopeverification exceptSetSlot(). I thinkSetSlot()does no-op fromEnvelopeVerifier's perspective in current implementation. Also, this corrects requirement list ofEnvelopeVerifier— uses its requirements instead of those ofPayloadAttMsgVerifier.