Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update holesky repository layout #14057

Merged
merged 5 commits into from
Jun 27, 2024
Merged

fix: update holesky repository layout #14057

merged 5 commits into from
Jun 27, 2024

Conversation

barnabasbusa
Copy link
Contributor

Fixes repository layout changes according to: eth-clients/holesky#104

@barnabasbusa barnabasbusa requested a review from a team as a code owner May 29, 2024 13:38
@prestonvanloon prestonvanloon self-assigned this Jun 4, 2024
@prestonvanloon
Copy link
Member

Thanks @barnabasbusa. This change won't work until we update the reference commit in the WORKSPACE.

We can merge this after eth-clients/holesky#104 merges.

@prestonvanloon prestonvanloon mentioned this pull request Jun 4, 2024
Merged
@barnabasbusa
Copy link
Contributor Author

@prestonvanloon PR 104 is now merged.

@james-prysm
Copy link
Contributor

james-prysm commented Jun 25, 2024 •
edited
Loading

@barnabasbusa

ERROR: /buildkite/builds/buildkite-2-1/prysmatic-labs/prysm/config/params/BUILD.bazel:41:8: Middleman _middlemen/config_Sparams_Sgo_Udefault_Utest_U_Sgo_Udefault_Utest-runfiles failed: missing input file '@@holesky_testnet//:metadata/config.yaml'
--
  | ERROR: /buildkite/builds/buildkite-2-1/prysmatic-labs/prysm/config/params/BUILD.bazel:41:8: Middleman _middlemen/config_Sparams_Sgo_Udefault_Utest_U_Sgo_Udefault_Utest-runfiles failed: 1 input file(s) do not exist

  hmm still seems to be broken

@barnabasbusa
Copy link
Contributor Author

The file path should be: metadata/config.yaml

https://github.com/eth-clients/holesky

@prestonvanloon
Copy link
Member

Fixed build in 6a04655

@prestonvanloon prestonvanloon added this pull request to the merge queue Jun 27, 2024
Merged via the queue into prysmaticlabs:develop with commit 5edc64d Jun 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@prestonvanloon prestonvanloon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnabasbusa @prestonvanloon @james-prysm