Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3signer: persistent public keys #13682
Web3signer: persistent public keys #13682
Changes from all commits
c1ce331
b1ae1c6
298dad3
bba48fc
6cbf248
10d68b6
7d9dc12
7839c7e
8e6e807
9a28ce1
f593585
41ee265
88dd412
649b85b
6836cb4
bb0b19f
79fdecb
195db90
b9fbdc0
164057e
aa5e389
34bd671
cb8d1a9
9fe695a
e72c7ee
769c660
ef5f310
94976cd
45e68fe
92487b1
331bc0d
07b83c9
ca40bc8
afd57da
e802cb1
db6cc41
f758edb
cd657d1
ccda2dc
c7057da
de8607a
d483c85
bc2ced5
eb145a3
83117ea
f523670
4918498
490b2c2
e219a6e
4139e10
d20d0fa
5c9a6e3
89f3517
d9ba22a
ea49fb8
c021a87
34e3655
304a0b8
0abf03a
94b8cca
cc3688f
847be70
f887357
f86aa24
854136d
5f1d4cc
34855b9
38fd716
3889213
b851ed2
8d597eb
e9b0b14
f1496d1
3a75ece
ee43c00
97b93fc
286eaf4
0f8646e
3af81ee
c9d384e
0e16b23
3bb8e1e
39dfb70
928b7f4
923b2f6
9ea7020
62ee999
d447fcf
b7a285f
23e0a8f
dd9eefb
915070c
3b7521e
eb12be5
beab34d
3faab52
87fc54c
edd7480
560c9c7
309d6ba
0b44203
05b37af
bb8da2f
a1cb673
eb99087
7e188f3
c506d8c
d759d88
9b5b78b
698889e
d76793d
ac4b063
70d279a
fe90f8f
1078f47
0470257
7bf0cab
a35f9bf
ce1565d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the word
Wallet
needed inWalletDir
?We already know it's a wallet, and writing
wallet.Dir
is more natural thanwallet.WalletDir
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good point i will change this I think I was just following naming of other parts of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WalletDir
is already accessible from outside. Why an accessor method is needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to follow the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted I left it as is, I don't think renaming to Directory helps, Dir is needed for the interface, and should be fixed as part of a greater wallet refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind
is already accessible from outside. Why an accessor method is needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to follow the interface for wallet