Web3signer: persistent public keys #13682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Web3Signer
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
reviewed
Jun 25, 2024
io/file/fileutil_test.go
Outdated
Comment on lines
586
to
591
| { | ||
| name: "overwrite existing file", | ||
| lines: []string{"line1", "line2"}, | ||
| filename: "testfile2.txt", | ||
| wantErr: false, | ||
| }, |
There was a problem hiding this comment.
Doesn't this test do exactly the same as the first one?
There was a problem hiding this comment.
need to fix this test
| return nil | ||
| } | ||
|
|
||
| func (km *Keymanager) areEmptyPublicKeys() bool { |
There was a problem hiding this comment.
arePublicKeysEmpty sounds better in my opinion
| return len(km.providedPublicKeys) == 0 | ||
| } | ||
|
|
||
| func (km *Keymanager) refreshRemoteKeysFromFileChanges(ctx context.Context) error { |
There was a problem hiding this comment.
Most of the logic is low-level logic independent of remote signer keys. If we move it to io/file, then we will be able to reuse such file watching in other places.
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
reviewed
Jun 26, 2024
| } | ||
| return errors.Wrap(err, "could not watch for file changes") | ||
| case <-ctx.Done(): | ||
| return nil |
There was a problem hiding this comment.
We probably want to log something here
rkapka
approved these changes
Jun 26, 2024
nalepae
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
currently prysm doesn't provide a way to persist api changes for web3signer keys using things like add or remove remote keys.
This pr provides a new flag
--validators-external-signer-key-file=/path/to/keyfile.txtwhere you can provide a list of your public keys in hex format on each line to be used with your web3signer. note,hex keys will require a0xprefix. if this flag is provided all keys provided via thevalidators-external-signer-public-keyscan also be saved if there are calls to the api. updating the file directly will also update the keys used without restart of the validator client( but caution as this part is still experimental)Which issues(s) does this PR fix?
Fixes #9994, #12373
Other notes for review