Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slasher: Fixes double votes false positive and attester slashings duplication. #13596

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Slasher: Fixes double votes false positive and attester slashings duplication. #13596

merged 5 commits into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. Test_processAttestations: Remove duplicated tests.

    @nalepae
    nalepae committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d254447 View commit details
    Browse the repository at this point in the history

  2. Sort indexed attestations by data root.

    @nalepae
    nalepae committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9ce96e5 View commit details
    Browse the repository at this point in the history

  3. processAttestations: Don't return duplicate slashings anymore. 

    Fix #13592.
    @nalepae
    nalepae committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c305778 View commit details
    Browse the repository at this point in the history

  4. AttesterDoubleVote: Rename fields.

    @nalepae
    nalepae committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b798f69 View commit details
    Browse the repository at this point in the history

  5. Detect double votes in different batches. 

    In order to do that:
1. Each attestation of the batch is tested against the other attestations of the batch.
2. Each attestation of the batch is tested against the content of the database.
2. Attestations are saved into the database.

Fixes #13590.
    @nalepae
    nalepae committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    544918c View commit details
    Browse the repository at this point in the history