Slasher: Fixes double votes false positive and attester slashings duplication. #13596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
force-pushed
the
slasher-double-votes-false-negative-13590
branch
3 times, most recently
from
f008348
to
c7daf0c
Compare
nalepae
changed the title
nalepae
changed the title
nalepae
force-pushed
the
slasher-double-votes-false-negative-13590
branch
from
c7daf0c
to
80883dc
Compare
nalepae
force-pushed
the
slasher-double-votes-false-negative-13590
branch
2 times, most recently
from
fecd735
to
ac2cecb
Compare
In order to do that: 1. Each attestation of the batch is tested against the other attestations of the batch. 2. Each attestation of the batch is tested against the content of the database. 2. Attestations are saved into the database. Fixes #13590.
nalepae
force-pushed
the
slasher-double-votes-false-negative-13590
branch
from
ac2cecb
to
544918c
Compare
rauljordan
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read this PR commit by commit.
What type of PR is this?
Bug fix
This pull requests fixes 2 bugs:
Double votes false positive
Redondant attester slashing objects sent
When an equivocating attestation is detected, then the same attester slashing object is sent multiple times. The number of copies of the same object depends of the number of validators actually slashable. This PR ensure that each attester slashing object is sent exactly once.
Which issues(s) does this PR fix?
[]*ethpb.AttesterSlashingare generated. #13592