config: return nil
on unknown option instead of raising
#2126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
nil
on unknown option was default behaviour for Pry v0.12.x. Ine5556a2 I changed that but I am not sure if it
was intentional. This breaks plugins such as
pry-theme (kyrylo/pry-theme#59).
Returning
nil
makes more sense, because we can write code like this:...whereas as of now this is no longer possible and you would need to use
respond_to?
to achieve the same effect.