Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Framework Base #1
Test Framework Base #1
Changes from 5 commits
cfdac49
f64f299
c8f5561
1e205fa
63f782b
855e741
44b8a72
1de9b3e
a8f1d21
ca1a3be
c7632ed
8ff60b1
927e7fe
9acd8f5
58a2b2c
eb7a846
b8e2404
c0150db
926c136
cb0da5f
a02242f
1fb96df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part of the same comment? Is this still accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'm basically keeping track of which expectations do not require a structure in expect_interface.rs, as they don't require an associate returning function. Hence, these expectations are set directly through tester.rs Tester methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be useful to list those host-functions in case a developer notices that their corresponding expect_interface.rs structure is not present. Also, in case of future ABI changes, where host-function signatures/function might change, and thus, a structure may need to be added for one of the commented functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make them part of the same comment section, using the same style-prefix?