Omit the _raw_default_instance_ declaration when using DLL linkage.
#17314
+13
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://github.com/avatars/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_648754789
branch
from
c71d483
to
cd88e34
Compare
In that mode we might not be able to make a `constexpr` pointer to the default instance. Omitting the declaration will only turn off an optimization, but the code will still be correct. Fixes #17303 PiperOrigin-RevId: 649160060
copybara-service
bot
force-pushed
the
test_648754789
branch
from
cd88e34
to
79c55cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit the
_raw_default_instance_declaration when using DLL linkage.In that mode we might not be able to make a
constexprpointer to the defaultinstance. Omitting the declaration will only turn off an optimization, but the
code will still be correct.
Fixes #17303