Require all Proxied types to be Sized. #17310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://github.com/avatars/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_648705298
branch
from
0316aff
to
02c28db
Compare
This is currently true and required by the IntoProxied trait. In Rust all type parameters are explicitly marked `Sized`, except for `Self` [1]. By marking `Proxied` as `Sized` we can write `IntoProxied<Self>` in generic code without having to add 'where Self: Sized` clauses. An implication of this change is that Proxied can no longer be used from a trait object i.e. `let x: dyn &Proxied = &foo` will not compile. We are not anticipating such use cases at this point. [1] https://doc.rust-lang.org/std/marker/trait.Sized.html PiperOrigin-RevId: 649010900
copybara-service
bot
force-pushed
the
test_648705298
branch
from
02c28db
to
73db255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require all Proxied types to be Sized.
This is currently true and required by the IntoProxied trait. In Rust all type parameters are explicitly marked
Sized, except forSelf[1]. By markingProxiedasSizedwe can writeIntoProxied<Self>in generic code without having to add 'where Self: Sized` clauses.An implication of this change is that Proxied can no longer be used from a trait object i.e.
let x: dyn &Proxied = &foowill not compile. We are not anticipating such use cases at this point.[1] https://doc.rust-lang.org/std/marker/trait.Sized.html