Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported Fix segmentation faults with enabled keep_descriptor_pool_after_request #17232

Conversation

simonberger
Copy link
Contributor

@simonberger simonberger commented Jun 25, 2024

Backports #16993
(cherry picked from commit e844510)

@simonberger simonberger requested a review from a team as a code owner June 25, 2024 16:59
@simonberger simonberger requested review from bshaffer and removed request for a team June 25, 2024 16:59
@simonberger
Copy link
Contributor Author

@haberman Sorry to mention you here, but looking at my last PR and others it unfortunately currently seems the only way to get some attention at a task.
It was a pity to see the 27.2 release coming without this fix inside.

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@haberman haberman self-requested a review July 8, 2024 17:58
@haberman haberman merged commit c1ec82f into protocolbuffers:27.x Jul 8, 2024
162 of 167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants