-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export PrivacyInfo.xcprivacy #17054
Export PrivacyInfo.xcprivacy #17054
Conversation
177bf58
to
640cb92
Compare
@mjburghard Could you rebase your branch against main and push it again? I believe that will fix the test failures. |
640cb92
to
4869cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know what the bazel rules are doing for CC or ObjC libraries to collect privacy manifest info. I would think something has to merge the data as other targets might need the info also.
Is exporting the file required, or do the rules use an aspect to collect the data from the whole graph an merge it?
@thomasvl I am not aware of any standard or any aspect that handles privacy manifests. One way possibility is to mimic the bundle spm would create using rules_apple and adding that as a data dependency. We currently do this in our repo, but have to copy the manifest as the file is not accessible at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but just copying the file likely isn't right since you'll need to merge it with the information for the rest of your code.
Yeah, this is part of a more elaborate setup. |
Are there any steps I can do to resolve the CI failure? |
Export `PrivacyInfo.xcprivacy` file to allow users of protobuf to access the file from Bazel, e.g. to bundle it with an iOS application. Closes #17054 COPYBARA_INTEGRATE_REVIEW=#17054 from mjburghard:export-privacy-manifest 4869cab FUTURE_COPYBARA_INTEGRATE_REVIEW=#17054 from mjburghard:export-privacy-manifest 4869cab PiperOrigin-RevId: 645386354
Export
PrivacyInfo.xcprivacy
file to allow users of protobuf to access the file from Bazel, e.g. to bundle it with an iOS application.