Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PrivacyInfo.xcprivacy #17054

Closed

Conversation

mjburghard
Copy link
Contributor

Export PrivacyInfo.xcprivacy file to allow users of protobuf to access the file from Bazel, e.g. to bundle it with an iOS application.

@mjburghard mjburghard marked this pull request as ready for review June 6, 2024 11:53
@mjburghard mjburghard requested a review from a team as a code owner June 6, 2024 11:53
@mjburghard mjburghard requested review from haberman and removed request for a team June 6, 2024 11:53
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 13, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 13, 2024
@acozzette
Copy link
Member

@mjburghard Could you rebase your branch against main and push it again? I believe that will fix the test failures.

@honglooker honglooker added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 17, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 17, 2024
@acozzette acozzette requested review from thomasvl and removed request for haberman June 17, 2024 18:37
Copy link
Contributor

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know what the bazel rules are doing for CC or ObjC libraries to collect privacy manifest info. I would think something has to merge the data as other targets might need the info also.

Is exporting the file required, or do the rules use an aspect to collect the data from the whole graph an merge it?

@mjburghard
Copy link
Contributor Author

mjburghard commented Jun 17, 2024

@thomasvl I am not aware of any standard or any aspect that handles privacy manifests. One way possibility is to mimic the bundle spm would create using rules_apple and adding that as a data dependency. We currently do this in our repo, but have to copy the manifest as the file is not accessible at the moment.
This PR only enables access for further handling by a user of protobuf.

Copy link
Contributor

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but just copying the file likely isn't right since you'll need to merge it with the information for the rest of your code.

@mjburghard
Copy link
Contributor Author

Yeah, this is part of a more elaborate setup.

@mjburghard
Copy link
Contributor Author

Are there any steps I can do to resolve the CI failure?

copybara-service bot pushed a commit that referenced this pull request Jun 28, 2024
Export `PrivacyInfo.xcprivacy` file to allow users of protobuf to access the file from Bazel, e.g. to bundle it with an iOS application.

Closes #17054

COPYBARA_INTEGRATE_REVIEW=#17054 from mjburghard:export-privacy-manifest 4869cab
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17054 from mjburghard:export-privacy-manifest 4869cab
PiperOrigin-RevId: 645386354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants