Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Scalar/MessageMapContainerTypes as virtual subclasses of MutableMapping instead of inheriting directly. #15999

Merged
1 commit merged into from
Mar 6, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Feb 28, 2024

Register Scalar/MessageMapContainerTypes as virtual subclasses of MutableMapping instead of inheriting directly.

This prevents these from using abc.ABCMeta metaclass to avoid deprecation warning:

DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.

Fixes #15077
Fixes #12186

@copybara-service copybara-service bot force-pushed the test_609782761 branch 3 times, most recently from 2bee52f to 80e7375 Compare March 6, 2024 01:42
…ableMapping instead of inheriting directly.

This prevents these from using abc.ABCMeta metaclass to avoid deprecation warning:
```
DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.
```

Fixes #15077
Fixes #12186

PiperOrigin-RevId: 613029479
@brcsw
Copy link

brcsw commented May 31, 2024

It seems likely that GCP's gcloud CLI is broken after this change: https://issuetracker.google.com/issues/343748810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants