-
Notifications
You must be signed in to change notification settings - Fork 15.4k
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP custom options not available #3065
Comments
Sorry that we don't support it currently. But it's on our plan.
…On Fri, May 5, 2017 at 14:21 Chris Muthig ***@***.***> wrote:
Is there any way currently access custom option values using the generated
PHP classes? It seems like when I add one to my proto file then my
generated class lists having an UninterpretedOption however I currently
see two problems:
1. The descriptor is private and there is no getter on the Message
class
2. The value of the option isn't saved anywhere that I can find
Are there plans to support this feature for PHP?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3065>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9H5fytWxB5l_poIX5Qv2rfcbwDS6Nmks5r25LpgaJpZM4NSb-7>
.
|
@TeBoring do you have any timeline for the functionality? |
Probably end of this quarter.
…On Fri, May 5, 2017 at 15:43 Chris Muthig ***@***.***> wrote:
@TeBoring <https://github.com/TeBoring> do you have any timeline for the
functionality?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3065 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9H5VWK8m4p-reJ_mOLO1s4DsT6tyAsks5r26YfgaJpZM4NSb-7>
.
|
Any chance this will be added in the near future? I'd like to use |
I don't have time for this feature now. Maybe early next year.
…On Wed, Nov 8, 2017 at 06:55 Francis Lavoie ***@***.***> wrote:
Any chance this will be added in the near future? I'd like to use
EnumValueOptions to associate a couple extra string fields with my enum.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3065 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9H5Zv10dYZja5JQ2EW46_IkuuM4g0Iks5s0cDqgaJpZM4NSb-7>
.
|
What is the status of this ticket? Is this on any roadmap, or is there any work in progress to implement this? Being able to use custom options in PHP would be huge for my team's use case, however it seems this ticket hasn't seen activity for almost 3 years now. |
I think PHP support for custom options should be achievable within the next six months. upb (the C library underlying PHP's extension) will soon be getting support for extensions, which is the last major hurdle to supporting custom options. |
Update: This is now supported in upb. We would need to prioritize creating the glue code to make it work. |
Custom options are supported in the "upb" C library that underlies that PECL extension, so all external blockers are removed. But there are several things that would need to be implemented at the PHP layer to offer this feature.
We don't have anyone working on this currently. |
PHP has the |
To use |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment. This issue is labeled |
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it. This issue was closed and archived because there has been no new activity in the 14 days since the |
Is there any way currently access custom option values using the generated PHP classes? It seems like when I add one to my proto file then my generated class lists having an
UninterpretedOption
however I currently see two problems:Message
classAre there plans to support this feature for PHP?
The text was updated successfully, but these errors were encountered: