Customer wrapper for Struct #929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't mean to create this PR against the upstream repo, but since I did, I'll leave it here for feedback. This PR adds a custom wrapper for the Struct type to convert between plain JS objects and the protobuf Struct type as described in #839. |
|
Any chance of getting this landed? |
|
Thanks for implementing this @tdterry. I found that this breaks optional objects by not null checking them in the generated code. I fixed it here (and implemented timestamp in there was well). Are you still working on this? Would be fun to get this into the mainline tree but I'm wondering whether I should start another PR or not. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.