Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the packed=true by default problem for proto2 files. #683

Closed
wants to merge 2 commits into from
Closed

Fixing the packed=true by default problem for proto2 files. #683

wants to merge 2 commits into from

Commits on Feb 20, 2017

  1. Update parse.js 

    This check is wrong as the types.packed fields includes only the built in primitive types. But at this point type of the repeated enum is a custom type like test.TestMessage therefore types.packed[type] !== undefined always returns false and code never enters that if condition and it does not set the packed flag to false. However when the syntax is set to proto2 this flag should be always set to false.
    @serkangunes
    serkangunes committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    75bc576 View commit details
    Browse the repository at this point in the history

  2. Update parse.js 

    Added support for turning on the packed option manually.
    @serkangunes
    serkangunes committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    dba295a View commit details
    Browse the repository at this point in the history