Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove return type requirement of pbjs callback #1025

Merged
merged 3 commits into from
May 18, 2018
Merged

remove return type requirement of pbjs callback #1025

merged 3 commits into from
May 18, 2018

Commits on Apr 25, 2018

  1. remove return type requirement of pbjs callback 

    The callback function of pbjs main should not enforce a return value.
    @vuryleo
    vuryleo committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    a4736c6 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. update pbjs callback type to the right one 

    https://github.com/dcodeIO/protobuf.js/blob/master/cli/pbjs.js#L20
    @vuryleo
    vuryleo committed May 2, 2018
    Configuration menu
    Copy the full SHA
    b6105c0 View commit details
    Browse the repository at this point in the history

  2. revert b6105c0 

    The type is not for the callback function,
    @vuryleo
    vuryleo committed May 2, 2018
    Configuration menu
    Copy the full SHA
    cdbd2de View commit details
    Browse the repository at this point in the history