Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.8.0 on npm #819

Closed
appedemic opened this issue Jun 2, 2017 · 4 comments
Closed

6.8.0 on npm #819

appedemic opened this issue Jun 2, 2017 · 4 comments

Comments

@appedemic
Copy link

protobuf.js version: 6.8.0

When installing with npm, I expected 6.8.0 to be installed but 6.7.3 is installed instead

npm install protobufjs
@FrobtheBuilder
Copy link

Please address this. The version on npm doesn't actually have decorator support, which is referenced directly in the current documentation.

@CallumBashford
Copy link

npm install https://github.com/dcodeIO/protobuf.js
The best we can do until its updated on npm.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 9, 2017

Currently going through the issues so I can publish 6.8.0. If you have some time, feel free to test master and let me know of any issues so I can fix them before publishing.

@FrobtheBuilder
Copy link

I'm using master (compiled manually) in my typescript project and the only issues I've had so far were some typing problems:

  • keeping @types/node in production dependencies conflicted with my project's own installation from npm (though that might not actually be a problem in normal usage, I'm keeping the package in a separate manually managed node_modules)
  • the codegen typings seem to have some issues with the latest version of typescript. Namely codegen.d.ts in the lib directory:
file: 'file:///.../src/node_modules/protobufjs/lib/codegen/index.d.ts'
severity: 'Error'
message: 'A 'declare' modifier is required for a top level declaration in a .d.ts file.'
at: '27,1'
source: 'ts'

I solved these by just ignoring the offending files in my tsconfig.json

"exclude": [
    "./node_modules",
    "./src/node_modules/protobufjs/node_modules/@types/node",
    "./src/node_modules/protobufjs/**/codegen/*.d.ts"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants