New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idempotent pbjs output generation #614

Closed

robin-anil opened this issue Jan 3, 2017 · 1 comment

Labels

Contributor

robin-anil commented Jan 3, 2017

We rely on pre-commit hooks, every time the pbjs is run, we expect same output. Can there be an --idempotent flag that strips out.

+// Generated Tue, 03 Jan 2017 22:32:22 UTC

The text was updated successfully, but these errors were encountered:

Contributor Author

robin-anil commented Jan 3, 2017 •

edited

Loading

Also these comments are causing webpack json-loader to barf. As it is no longer a valid json object

dcodeIO added a commit that referenced this issue


          CLI: pbjs/pbts no longer generate any volatile headers, see #614

ee20b81

dcodeIO added the enhancement label

robin-anil closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment