Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options parser exception parsing multiple options in same code block #383

Closed
grier opened this issue Jan 8, 2016 · 2 comments
Closed

options parser exception parsing multiple options in same code block #383

grier opened this issue Jan 8, 2016 · 2 comments

Comments

@grier
Copy link

grier commented Jan 8, 2016

A proto file with options like:

option (toplevel_3.options) = {
  opt1: true,
  opt2: "Support multiple options in the same block"
};

Causes exceptions when parsing:

 Parse error at line 5: illegal option name: (toplevel_3.options).,
    Error: Parse error at line 5: illegal option name: (toplevel_3.options).,
@mikhailmikhaylov
Copy link

Is there any chance that this will be resolved soon?

@dcodeIO
Copy link
Member

dcodeIO commented Nov 28, 2016

Closing this for now.

protobuf.js 6.0.0

Feel free to send a pull request if this is still a requirement.

@dcodeIO dcodeIO closed this as completed Nov 28, 2016
drigz added a commit to drigz/protobuf.js that referenced this issue Mar 15, 2018
More information on the "Aggregate Syntax" here:
protocolbuffers/protobuf#1148

These are accepted by the proto compiler but rarely used - I found an
example in the
[Cloud Endpoints docs](https://cloud.google.com/endpoints/docs/grpc-service-config/reference/rpc/google.api#google.api.HttpRule.FIELDS.string.google.api.HttpRule.rest_method_name).

Fixes protobufjs#383.
drigz added a commit to drigz/protobuf.js that referenced this issue Mar 15, 2018
More information on the "Aggregate Syntax" here:
protocolbuffers/protobuf#1148

These are accepted by the proto compiler but rarely used - I found an
example in the
[Cloud Endpoints docs](https://cloud.google.com/endpoints/docs/grpc-service-config/reference/rpc/google.api#google.api.HttpRule.FIELDS.string.google.api.HttpRule.rest_method_name).

Fixes protobufjs#383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants