-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation errors running CLI #1368
Comments
Note: We have multiple machines failing with this error |
The CLI and the browser runtime source code are in one package. Most people are only using protobuf.js for their runtime dep. For providing a smaller installed size, the author does not install the CLI's dependencies by default. Only when the CLI is used will it check whether it's dependencies were installed. If not, it will start a child process to install them. The child process would execute an |
Is there a mitigation for this? We tried including the libraries in our own package.json but it still installs them anyway. |
Because the libraries are installed in https://github.com/protobufjs/protobuf.js/blob/master/cli/pbjs.js#L7 |
I don't have the option to modify the files inside node_modules as this issue is happening during build on a machines that run |
This is so annoying. Installing packages dynamically!? it should be avoided. |
Agreed @cainiaokan . It's easy to avoid because NPM is specifically built the way it's built to avoid things like this. |
Any update on this? That is 100% accurate in that it should be avoided |
add |
|
Any update? |
It looks like there's a PR that could fix this by divorcing the CLI from the main package. Last updated 3 days ago: #1234 |
Same problem with version 6.11.2. |
Does not happen on version |
Was having this error during building: protobufjs/protobuf.js#1368
* Update to 0.19.0 * Update update script * Revert "Update to 0.19.0" This reverts commit 7edc75e. * Non-mono * Mono * Fix build * Fix linting * Update interceptors version * Add protobuf sample * Add generated files to .gitignore * README and prettier * Fix proto build Was having this error during building: protobufjs/protobuf.js#1368
Fixed for me with |
Any solution? Now I fixed it by |
* Update to 0.19.0 * Update update script * Revert "Update to 0.19.0" This reverts commit 7edc75e6c699609235b87844e82497ac76a95d61. * Non-mono * Mono * Fix build * Fix linting * Update interceptors version * Add protobuf sample * Add generated files to .gitignore * README and prettier * Fix proto build Was having this error during building: protobufjs/protobuf.js#1368
protobuf.js version: 6.8.8
Expected: Protobufjs runs and installs dependencies
Actual: Protobufjs fails to install dependencies
Any ideas for how to mitigate this?
The text was updated successfully, but these errors were encountered: