Added codegen test to determine if any ancient browsers don't actuall…

…y support it
protobufjs · Dec 18, 2016 · c234de7 · c234de7
1 parent 19e906c
commit c234de7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/namespace.js b/src/namespace.js
@@ -283,9 +283,8 @@ NamespacePrototype.lookup = function lookup(path, filterType, parentAlreadyCheck
         return this.getRoot().lookup(path.slice(1), filterType);
     // Test if the first part matches any nested object, and if so, traverse if path contains more
     var found = this.get(path[0]);
-    if (found && path.length === 1 || found instanceof Namespace && (found = found.lookup(path.slice(1), true)))
-        if (!filterType || found instanceof filterType)
-            return found;
+    if (found && path.length === 1 && (!filterType || found instanceof filterType) || found instanceof Namespace && (found = found.lookup(path.slice(1), filterType, true)))
+        return found;
     // If there hasn't been a match, try again at the parent
     if (this.parent === null || parentAlreadyChecked)
         return null;

diff --git a/tests/codegen.js b/tests/codegen.js
@@ -0,0 +1,8 @@
+var tape = require("tape");
+
+var protobuf = require("..");
+
+tape.test("codegen", function(test) {
+    test.equal(protobuf.util.codegen.supported, true, "should be supported");
+    test.end();
+});